Skip to content

Conversation

@john0isaac
Copy link
Contributor

@john0isaac john0isaac commented Jul 24, 2024

Purpose

This PR adds playwright tests.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

@john0isaac john0isaac force-pushed the add-playwright-tests branch from 5c708e0 to c26d3f2 Compare July 29, 2024 22:12
@pamelafox
Copy link
Contributor

I'm just running the CI on Windows myself to see for myself/ get a link for reporting.

@pamelafox
Copy link
Contributor

@john0isaac Filed @ microsoft/playwright-python#2506

@pamelafox
Copy link
Contributor

Only running on Mac now, merging. Thanks so much!

@pamelafox pamelafox merged commit 964ee33 into Azure-Samples:main Aug 1, 2024
@john0isaac john0isaac deleted the add-playwright-tests branch August 1, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants